incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Enhancements for get-third-party.sh script.
Date Mon, 21 Jan 2013 19:09:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9045/#review15548
-----------------------------------------------------------


Regarding chmod a+x -> I did it but I think that since I am am using git-svn with msysgit
on windows it ignores the modifier :(
I ll try to do the commit with git running in cygwin, hopefully that will help.

- Yuri Zelikov


On Jan. 21, 2013, 7:05 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9045/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2013, 7:05 p.m.)
> 
> 
> Review request for wave, Vicente J. Ruiz Jurado and Ali Lown.
> 
> 
> Description
> -------
> 
> Enhancements for get-third-party.sh script.
> 1.Renames the script to use "-" instead of "_" to comply with the naming policy
> 2. Adds validation to the build.xml to warn in case the test dependencies are missing.
> 
> 
> Diffs
> -----
> 
>   README da77f49 
>   build.properties c476a82 
>   build.xml 3d3c125 
>   get-third-party.sh PRE-CREATION 
>   get_third_party.sh d8b1ce2 
> 
> Diff: https://reviews.apache.org/r/9045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message