incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: RegistrationUtil new checkNewUsername function
Date Wed, 16 Jan 2013 16:20:20 GMT


> On Nov. 9, 2012, 7:47 a.m., Yuri Zelikov wrote:
> > src/org/waveprotocol/box/server/util/RegistrationUtil.java, line 42
> > <https://reviews.apache.org/r/7903/diff/2/?file=185975#file185975line42>
> >
> >     Check -> Checks

Committed as r1434014


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7903/#review13286
-----------------------------------------------------------


On Nov. 6, 2012, 8:11 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7903/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 8:11 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> Minor review: This patch creates a new method in RegistrationUtil that makes possible
to reuse this portion of the code.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 17359bb 
>   src/org/waveprotocol/box/server/util/RegistrationUtil.java 52e0626 
> 
> Diff: https://reviews.apache.org/r/7903/diff/
> 
> 
> Testing
> -------
> 
> Some registrations tests (with correct and incorrect usernames).
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message