incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request: Internationalization and partial localization to Russian, French and Slovenian languages.
Date Fri, 11 Jan 2013 10:05:59 GMT


> On Jan. 10, 2013, 12:57 p.m., Ali Lown wrote:
> > ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages.java, line 15
> > <https://reviews.apache.org/r/8916/diff/2/?file=246577#file246577line15>
> >
> >     Why are you setting the default message here as well? This is duplicating the
message between this file and the properties file.
> 
> Andrew Kaplanov wrote:
>     GWT does not compile resources without default messages.

The workaround detailed here[0] using set-property-fallback and set-property-name is meant
to bypass this requirement. It has been in the gwt bug tracker since Dec 2010. I would much
rather force English as the default locale with this, than have to maintain 2 lots of resources.

[0]: https://code.google.com/p/google-web-toolkit/issues/detail?id=5769#c1


- Ali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8916/#review15237
-----------------------------------------------------------


On Jan. 10, 2013, 9:04 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8916/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 9:04 p.m.)
> 
> 
> Review request for wave.
> 
> 
> Description
> -------
> 
> Realizes the possibility of switching and storing the user's language.
> Most phrases have been translated into several languages.
> 
> 
> Diffs
> -----
> 
>   ./proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java
1430452 
>   ./src/org/waveprotocol/box/server/ServerMain.java 1430452 
>   ./src/org/waveprotocol/box/server/account/HumanAccountData.java 1430452 
>   ./src/org/waveprotocol/box/server/account/HumanAccountDataImpl.java 1430452 
>   ./src/org/waveprotocol/box/server/gxp/TopBar.gxp 1430452 
>   ./src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp 1430452 
>   ./src/org/waveprotocol/box/server/persistence/protos/ProtoAccountDataSerializer.java
1430452 
>   ./src/org/waveprotocol/box/server/persistence/protos/account-store.proto 1430452 
>   ./src/org/waveprotocol/box/server/rpc/LocaleServlet.java PRE-CREATION 
>   ./src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 1430452 
>   ./src/org/waveprotocol/box/server/util/URLParameters.java PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/WebClientProd.gwt.xml 1430452 
>   ./src/org/waveprotocol/box/webclient/client/LocaleService.java PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/client/RemoteLocaleService.java PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/client/SavedStateIndicator.java 1430452 
>   ./src/org/waveprotocol/box/webclient/client/Session.java 1430452 
>   ./src/org/waveprotocol/box/webclient/client/WebClient.java 1430452 
>   ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages_en.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SavedStateMessages_ru.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_en.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_fr.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/SessionMessages_ru.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_en.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_fr.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_ru.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/client/i18n/WebClientMessages_sl.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/DigestDomImpl.java 1430452 
>   ./src/org/waveprotocol/box/webclient/search/SearchPresenter.java 1430452 
>   ./src/org/waveprotocol/box/webclient/search/SearchWidget.ui.xml 1430452 
>   ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_en.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_fr.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/DigestDomMessages_ru.properties PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchPresenterMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/search/i18n/SearchWidgetMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/error/ErrorIndicatorWidget.ui.xml 1430452

>   ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/error/i18n/ErrorMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/loading/LoadingIndicator.ui.xml 1430452

>   ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages.java PRE-CREATION

>   ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/box/webclient/widget/loading/i18n/LoadingMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/StageThree.java 1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/event/EventDispatcherPanel.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/event/EventHandlerRegistry.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/event/WaveChangeHandler.java PRE-CREATION

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/ActionsImpl.java 1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages.java PRE-CREATION

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ActionMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/edit/i18n/ParticipantMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/MenuController.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages.java PRE-CREATION

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/menu/i18n/MenuMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/ViewToolbar.java 1430452

>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/AttachmentPopupWidget.ui.xml
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/i18n/AttachmentMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.java
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetSelectorWidget.ui.xml
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetCategoryMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/i18n/GadgetSelectorMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/LinkerMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/i18n/ToolbarMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipLinkPopupWidget.ui.xml
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ParticipantsViewBuilder.java
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ReplyBoxViewBuilder.java
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/WavePanelResourceLoader.java
1430452 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipLinkMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages.java PRE-CREATION

>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/BlipMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ParticipantMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages.java
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/wavepanel/view/dom/full/i18n/ReplyBoxMessages_sl.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/widget/profile/ProfilePopupWidget.java 1430452 
>   ./src/org/waveprotocol/wave/client/widget/profile/ProfilePopupWidget.ui.xml 1430452

>   ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages.java PRE-CREATION

>   ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_en.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_fr.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_ru.properties
PRE-CREATION 
>   ./src/org/waveprotocol/wave/client/widget/profile/i18n/ProfilePopupMessages_sl.properties
PRE-CREATION 
>   ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipViewBuilderTest.java
1430452 
>   ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/ReplyBoxBuilderTest.java
1430452 
>   ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/RootThreadViewBuilderTest.java
1430452 
>   ./test/org/waveprotocol/wave/client/wavepanel/view/dom/full/UiBuilderTestHelper.java
1430452 
>   ./war/static/earth.png UNKNOWN 
> 
> Diff: https://reviews.apache.org/r/8916/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message