incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael MacFadden" <michael.macfad...@gmail.com>
Subject Re: Review Request: Adds get_third_party script to download junit and emma dependencies
Date Thu, 20 Dec 2012 02:31:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8630/#review14745
-----------------------------------------------------------

Ship it!


At this point I think this looks good enought to commit.  I think we can probably put it in
there and have a few people try it.  If for some reason we need to modify it, we can make
changes later. 

- Michael MacFadden


On Dec. 18, 2012, 8:25 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8630/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2012, 8:25 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> Adds get_third_party script to download junit and emma dependencies.
> It also updates the junit to version 4.10 since I couldn't find download for the old
3.8.2 version.
> 
> 
> Diffs
> -----
> 
>   .gitignore 151cca9 
>   README eba3b57 
>   get_third_party.sh PRE-CREATION 
>   third_party/test/emma/emma.jar 52f80e5 
>   third_party/test/emma/emma_ant.jar ee5134b 
>   third_party/test/junit/README.google f92d92b 
>   third_party/test/junit/junit.jar c8f711d 
>   third_party/test/junit/src.jar 28ea5fc 
> 
> Diff: https://reviews.apache.org/r/8630/diff/
> 
> 
> Testing
> -------
> 
> Executed "ant test"
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message