incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wavegr...@gmail.com
Subject Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"
Date Tue, 18 Dec 2012 18:24:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7683/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 6:24 p.m.)


Review request for wave.


Changes
-------

Reverted back to using the original Snippet class and updated the client side snippets to
work the same way as the server side snippets - Trimming away the title if it exist in the
snippet

Also verified so that this patch still applies without conflicts on the current version of
the git repo.

Please review, thanks.


Description
-------

Fix for "SimpleSearch.DigestProxy should undate only the opened wave on changes". Also updated
so that the active digest update its title and snippet in real time to make it feel more responsive
and live.

There might still be some code tweaks I should do and I still have two TODOs in my code that
I need to fix.

Any feedback on the patch are welcome. Thanks!


This addresses bug WAVE-354.
    https://issues.apache.org/jira/browse/WAVE-354


Diffs (updated)
-----

  src/org/waveprotocol/box/common/Snippets.java 099ce55 
  src/org/waveprotocol/box/webclient/search/SearchPanelView.java e922fd4 
  src/org/waveprotocol/box/webclient/search/SearchPanelWidget.java 4402b8e 
  src/org/waveprotocol/box/webclient/search/SearchPresenter.java b136c88 
  src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5b018d4 
  src/org/waveprotocol/box/webclient/search/WaveBasedDigest.java 8d3cb92 
  src/org/waveprotocol/wave/concurrencycontrol/wave/CcBasedWavelet.java e87b1e0 
  src/org/waveprotocol/wave/model/wave/Wavelet.java a463d45 
  src/org/waveprotocol/wave/model/wave/opbased/OpBasedWavelet.java e99067c 

Diff: https://reviews.apache.org/r/7683/diff/


Testing
-------

It would be good with some unit tests for the TitleHelper and the Snippet classes but I don't
think there currently are any good mock classes to use for that.

I tested manually on a locally running server.


Thanks,

rocklund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message