incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angus Turner" ...@theangus.org>
Subject Re: Review Request: Adds get_third_party script to download junit and emma dependencies
Date Sun, 16 Dec 2012 22:49:08 GMT


> On Dec. 16, 2012, 10:39 p.m., Ali Lown wrote:
> > get_third_party.sh, line 27
> > <https://reviews.apache.org/r/8630/diff/2/?file=239263#file239263line27>
> >
> >     Trying to use these, without checking for the existence of said program is only
going to cause problems.
> >     
> >     I don't think it will work on OSX either. (Normally, openssl sha1 is used, though
I don't have one to test on).

Can confirm that sha1sum doesn't work on OSX. openssl sha1 seems to work though.


- Angus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8630/#review14572
-----------------------------------------------------------


On Dec. 16, 2012, 10:30 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8630/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2012, 10:30 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> Adds get_third_party script to download junit and emma dependencies.
> It also updates the junit to version 4.10 since I couldn't find download for the old
3.8.2 version.
> 
> 
> Diffs
> -----
> 
>   README eba3b57 
>   get_third_party.sh PRE-CREATION 
>   third_party/test/emma/emma.jar 52f80e5 
>   third_party/test/emma/emma_ant.jar ee5134b 
>   third_party/test/junit/README.google f92d92b 
>   third_party/test/junit/junit.jar c8f711d 
>   third_party/test/junit/src.jar 28ea5fc 
> 
> Diff: https://reviews.apache.org/r/8630/diff/
> 
> 
> Testing
> -------
> 
> Executed "ant test"
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message