incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix for WAVE-334 gadget border
Date Mon, 03 Dec 2012 22:07:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8327/#review13994
-----------------------------------------------------------


LGTM, but I am not sure regarding the borders removal. Is it OK with everybody?

- Yuri Zelikov


On Dec. 3, 2012, 7:57 p.m., Nikolay Volnov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8327/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 7:57 p.m.)
> 
> 
> Review request for wave.
> 
> 
> Description
> -------
> 
> It is a fix for https://issues.apache.org/jira/browse/WAVE-334
> 
> I've set 0 for a gadget border. See screenshots.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/gadget/renderer/Gadget.css 264a87a 
>   src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidgetUi.java 3574fee 
> 
> Diff: https://reviews.apache.org/r/8327/diff/
> 
> 
> Testing
> -------
> 
> run unit tests
> tested manually on local server 
> 
> 
> Screenshots
> -----------
> 
> new version (without borders)
>   https://reviews.apache.org/r/8327/s/17/
> before the fix
>   https://reviews.apache.org/r/8327/s/18/
> 
> 
> Thanks,
> 
> Nikolay Volnov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message