incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Export and Import.
Date Sun, 25 Nov 2012 22:53:04 GMT


> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote:
> > ./src/org/waveprotocol/box/expimp/DomainConverter.java, line 132
> > <https://reviews.apache.org/r/7958/diff/4/?file=188619#file188619line132>
> >
> >     Can we extract the address part without parsing the participantId?
> >     Like ParticipantId.of(participant).getAddress()
> 
> Andrew Kaplanov wrote:
>     No, ParticipantId.of(participant).getAddress() is participant with normalization.

Can you add then appropriate method to ParticipantId? We should not relay on internal representation
of outside of ParticipantId


> On Nov. 17, 2012, 11:01 a.m., Yuri Zelikov wrote:
> > ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java, line 388
> > <https://reviews.apache.org/r/7958/diff/4/?file=188629#file188629line388>
> >
> >     Why null and not "ImmutableList.of();"
> 
> Andrew Kaplanov wrote:
>     That an error response, not as for wavelet not having deltas.

I think such distinction is confusing. We better not return nulls unless we really need such
logic.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7958/#review13539
-----------------------------------------------------------


On Nov. 25, 2012, 7:12 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7958/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2012, 7:12 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Description
> -------
> 
> Export/Import client utilities and support on the server.
> Replaces utilities for export from GWave and import to Wiab.
> Released on DataAPI and RobotAPI.
> See README.export-import for tutorial.
> 
> 
> Diffs
> -----
> 
>   ./README.export-import PRE-CREATION 
>   ./README.import 1413384 
>   ./build.properties 1413384 
>   ./build.xml 1413384 
>   ./run-export.sh 1413384 
>   ./run-import.sh 1413384 
>   ./server-config.xml 1413384 
>   ./server.config.example 1413384 
>   ./src/com/google/wave/api/JsonRpcConstant.java 1413384 
>   ./src/com/google/wave/api/OperationQueue.java 1413384 
>   ./src/com/google/wave/api/OperationType.java 1413384 
>   ./src/com/google/wave/api/WaveService.java 1413384 
>   ./src/com/google/wave/api/event/WaveletFetchedEvent.java 1413384 
>   ./src/com/google/wave/api/impl/GsonFactory.java 1413384 
>   ./src/com/google/wave/api/impl/JsonRpcResponseGsonAdaptor.java 1413384 
>   ./src/com/google/wave/api/impl/OperationRequestGsonAdaptor.java 1413384 
>   ./src/com/google/wave/api/impl/RawAttachmentData.java PRE-CREATION 
>   ./src/com/google/wave/api/impl/RawDeltas.java PRE-CREATION 
>   ./src/com/google/wave/api/impl/RawDeltasListener.java PRE-CREATION 
>   ./src/org/waveprotocol/box/common/ListReceiver.java PRE-CREATION 
>   ./src/org/waveprotocol/box/common/Receiver.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/Console.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/DeltaParser.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/DomainConverter.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/FileNames.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/OAuth.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/WaveExport.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/WaveImport.java PRE-CREATION 
>   ./src/org/waveprotocol/box/server/CoreSettings.java 1413384 
>   ./src/org/waveprotocol/box/server/ServerMain.java 1413384 
>   ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizationCodePage.gxp PRE-CREATION 
>   ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizeTokenPage.gxp 1413384 
>   ./src/org/waveprotocol/box/server/persistence/file/FileDeltaCollection.java 1413384

>   ./src/org/waveprotocol/box/server/persistence/memory/MemoryDeltaCollection.java 1413384

>   ./src/org/waveprotocol/box/server/robots/OperationContext.java 1413384 
>   ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java 1413384 
>   ./src/org/waveprotocol/box/server/robots/RobotApiModule.java 1413384 
>   ./src/org/waveprotocol/box/server/robots/active/ActiveApiOperationServiceRegistry.java
1413384 
>   ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java 1413384 
>   ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOperationServiceRegistry.java
1413384 
>   ./src/org/waveprotocol/box/server/robots/operations/ExportAttachmentService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ExportSnapshotService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/FetchWaveService.java 1413384 
>   ./src/org/waveprotocol/box/server/robots/operations/ImportAttachmentService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java 1413384

>   ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletDeltaRecord.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletProvider.java 1413384 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletState.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/WaveExport.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/WaveImport.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/RobotApi.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java 1413384

>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java
1413384 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java 1413384

>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java 1413384

>   ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java 1413384 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java 1413384 
>   ./src/org/waveprotocol/wave/model/image/ImageConstants.java PRE-CREATION 
>   ./test/org/waveprotocol/box/expimp/DeltaParserTest.java PRE-CREATION 
>   ./test/org/waveprotocol/box/expimp/DomainConverterTest.java PRE-CREATION 
>   ./test/org/waveprotocol/box/server/frontend/ClientFrontendImplTest.java 1413384 
>   ./test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java 1413384

>   ./test/org/waveprotocol/box/server/rpc/WaveletProviderStub.java 1413384 
>   ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java 1413384 
>   ./test/org/waveprotocol/box/server/waveserver/WaveletStateTestBase.java 1413384 
>   ./third_party/runtime/google-api-client/COPYING 1413384 
>   ./third_party/runtime/google-api-client/README 1413384 
>   ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar 1413384 
>   ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar 1413384 
>   ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar 1413384

> 
> Diff: https://reviews.apache.org/r/7958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message