incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Kaplanov" <akapla...@gmail.com>
Subject Re: Review Request: Export and Import.
Date Mon, 12 Nov 2012 09:06:20 GMT


> On Nov. 10, 2012, 5:31 p.m., Yuri Zelikov wrote:
> > ./src/com/google/wave/api/WaveService.java, line 89
> > <https://reviews.apache.org/r/7958/diff/2/?file=186881#file186881line89>
> >
> >     Why use this additional field?
> 
> Andrew Kaplanov wrote:
>     To can redefine default timeout value;
> 
> Yuri Zelikov wrote:
>     Can we maybe add some method to change it and then return it back? Or maybe pass
some startup up parameter that defines timeout. Is there any use for timeout in those methods
besides import/export?.
>     In any way, those methods do almost the same thing, I believe if we need both signatures
- we still can extract some common code and re-use it.
> 
> Andrew Kaplanov wrote:
>     In my opinion this timeout by default must be 0, i.e. unlimited.
>     Seems to be far-fetched, these 10 seconds of waiting, why not 20 or 30? Any request
may take longer at busy server.
>     Can simply assign URLFETCH_TIMEOUT_IN_MS = 0?
>     
>     With regards to re-use, I think it can only refer to DeltaStoreBasedWaveletState.readDeltasInRange().

>     But then have to determine the timeout value equal to infinity to separate the two
use the same function.
> 
> Yuri Zelikov wrote:
>     I would prefer a solution that will enable to configure the url fetch timeout. How
about adding additional property to server.config?
> 
> Andrew Kaplanov wrote:
>     Is it about client library? server.config refers to the server.
> 
> Yuri Zelikov wrote:
>     I mean, can we add URLFETCH_TIMEOUT_IN_MS to server.config properties, so it would
be possible to define this value on startup?
> 
> Andrew Kaplanov wrote:
>     URLFETCH_TIMEOUT_IN_MS refers to client Robot API, not to server.
> 
> Yuri Zelikov wrote:
>     Sorry, I was talking about the "timeout" parameter you added to various methods.
The question is - can we skip adding those new methods with timeout argument and instead have
some global value that can be changed?
> 
> Andrew Kaplanov wrote:
>     No, these functions are different in meaning. Kernel functions take strict range
of deltas and must return all or nothing, in case of failure. Function to export returns all
requested deltas of prepared for a specified period of time.

typo:
Function to export returns all requested deltas OR prepared for a specified period of time.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7958/#review13289
-----------------------------------------------------------


On Nov. 10, 2012, 8:18 p.m., Andrew Kaplanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7958/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 8:18 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Description
> -------
> 
> Export/Import client utilities and support on the server.
> Replaces utilities for export from GWave and import to Wiab.
> Released on DataAPI and RobotAPI.
> See README.export-import for tutorial.
> 
> 
> Diffs
> -----
> 
>   ./README.export-import PRE-CREATION 
>   ./README.import 1406525 
>   ./build.properties 1406525 
>   ./build.xml 1406525 
>   ./run-export.sh 1406525 
>   ./run-import.sh 1406525 
>   ./server-config.xml 1406525 
>   ./server.config.example 1406525 
>   ./src/com/google/wave/api/JsonRpcConstant.java 1406525 
>   ./src/com/google/wave/api/OperationQueue.java 1406525 
>   ./src/com/google/wave/api/OperationType.java 1406525 
>   ./src/com/google/wave/api/WaveService.java 1406525 
>   ./src/com/google/wave/api/event/WaveletFetchedEvent.java 1406525 
>   ./src/com/google/wave/api/impl/AttachmentData.java PRE-CREATION 
>   ./src/com/google/wave/api/impl/GsonFactory.java 1406525 
>   ./src/com/google/wave/api/impl/JsonRpcResponseGsonAdaptor.java 1406525 
>   ./src/com/google/wave/api/impl/RawDeltas.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/Console.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/DeltaParser.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/DomainConverter.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/FileNames.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/OAuth.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/WaveExport.java PRE-CREATION 
>   ./src/org/waveprotocol/box/expimp/WaveImport.java PRE-CREATION 
>   ./src/org/waveprotocol/box/server/CoreSettings.java 1406525 
>   ./src/org/waveprotocol/box/server/ServerMain.java 1406525 
>   ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizationCodePage.gxp PRE-CREATION 
>   ./src/org/waveprotocol/box/server/gxp/OAuthAuthorizeTokenPage.gxp 1406525 
>   ./src/org/waveprotocol/box/server/robots/OperationContext.java 1406525 
>   ./src/org/waveprotocol/box/server/robots/OperationContextImpl.java 1406525 
>   ./src/org/waveprotocol/box/server/robots/RobotApiModule.java 1406525 
>   ./src/org/waveprotocol/box/server/robots/active/ActiveApiOperationServiceRegistry.java
1406525 
>   ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServlet.java 1406525 
>   ./src/org/waveprotocol/box/server/robots/dataapi/DataApiOperationServiceRegistry.java
1406525 
>   ./src/org/waveprotocol/box/server/robots/operations/ExportAttachmentService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ExportDeltasService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ExportSnapshotService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/FetchWaveService.java 1406525 
>   ./src/org/waveprotocol/box/server/robots/operations/ImportAttachmentService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/robots/operations/ImportDeltasService.java PRE-CREATION

>   ./src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java 1406525

>   ./src/org/waveprotocol/box/server/waveserver/ImportServlet.java 1406525 
>   ./src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 1406525 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletContainer.java 1406525 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java 1406525 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletProvider.java 1406525 
>   ./src/org/waveprotocol/box/server/waveserver/WaveletState.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/WaveExport.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/WaveImport.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/RobotApi.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigest.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestGsonImpl.java 1406525

>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestImpl.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/RobotSearchDigestUtil.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/NeedNewOAuthTokenException.java
1406525 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthCredentials.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthRequestHelper.java 1406525

>   ./src/org/waveprotocol/box/waveimport/google/oauth/OAuthedFetchService.java 1406525

>   ./src/org/waveprotocol/box/waveimport/google/oauth/StableUserId.java 1406525 
>   ./src/org/waveprotocol/box/waveimport/google/oauth/UserContext.java 1406525 
>   ./src/org/waveprotocol/wave/model/image/ImageConstants.java PRE-CREATION 
>   ./test/org/waveprotocol/box/expimp/DomainConverterTest.java PRE-CREATION 
>   ./test/org/waveprotocol/box/server/robots/dataapi/DataApiOAuthServletTest.java 1406525

>   ./test/org/waveprotocol/box/server/rpc/WaveletProviderStub.java 1406525 
>   ./test/org/waveprotocol/box/server/waveserver/ImportServletTest.java 1406525 
>   ./third_party/runtime/google-api-client/COPYING 1406525 
>   ./third_party/runtime/google-api-client/README 1406525 
>   ./third_party/runtime/google-api-client/google-api-client-1.5.0-beta.jar 1406525 
>   ./third_party/runtime/google-api-client/google-http-client-1.5.0-beta.jar 1406525 
>   ./third_party/runtime/google-api-client/google-oauth-client-1.5.0-beta.jar 1406525

> 
> Diff: https://reviews.apache.org/r/7958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Kaplanov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message