incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wavegr...@gmail.com
Subject Review Request: Fixed so that GadgetWidget properly use its saved height for faster wave loading
Date Sat, 10 Nov 2012 16:50:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8008/
-----------------------------------------------------------

Review request for wave.


Description
-------

GadgetWidget already have a saved height property to be able to load its correct height faster
when a wave is loaded. This property was however not properly used so gadget heights got changed
several times during wave loading, forcing the user to wait until all gadgets was loaded until
he/she could start to read the wave.

This patch fixes so that gadgets load with their saved heights if they have any. A new height
is saved when the user perform an action on the gadget that causes its height to be changed.
This greatly improves the perceived load time of waves with many gadgets.


Please review, thanks!


Diffs
-----

  src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidget.java f89abfd 
  src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidgetUi.java 50b205d 

Diff: https://reviews.apache.org/r/8008/diff/


Testing
-------

Tested on locally run server with most of the gadgets. Trying both the more static gadgets
and the gadgets that have more dynamic heights.


Thanks,

rocklund


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message