incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: RegistrationUtil new checkNewUsername function
Date Tue, 06 Nov 2012 20:11:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7903/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 8:11 p.m.)


Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.


Changes
-------

Removed Log warning (because it's not used here).


Description
-------

Minor review: This patch creates a new method in RegistrationUtil that makes possible to reuse
this portion of the code.


Diffs (updated)
-----

  src/org/waveprotocol/box/server/rpc/UserRegistrationServlet.java 17359bb 
  src/org/waveprotocol/box/server/util/RegistrationUtil.java 52e0626 

Diff: https://reviews.apache.org/r/7903/diff/


Testing
-------

Some registrations tests (with correct and incorrect usernames).


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message