incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request: Fixed server-config.xml typo
Date Tue, 06 Nov 2012 13:00:10 GMT


> On Nov. 6, 2012, 12:56 p.m., Ali Lown wrote:
> > LGTM. Sorry I caused all 3 of those in the client-auth patch set.

Committed as r1406117.


- Ali


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7899/#review13142
-----------------------------------------------------------


On Nov. 6, 2012, 12:55 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7899/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 12:55 p.m.)
> 
> 
> Review request for wave, Yuri Zelikov and Ali Lown.
> 
> 
> Description
> -------
> 
> There is some typos in server-config.xml after https://reviews.apache.org/r/4994/
> with this result:
> 
> $ ant -f server-config.xml -Dwave_server_domain=localhost
> Buildfile: /home/vjrj/proyectos/dev/wave/wiab/svn-git-trunk/server-config.xml
> 
> create-folders:
> 
> server-config:
>      [echo] Generating server.config
>      [copy] Copying 1 file to /home/vjrj/proyectos/dev/wave/wiab/svn-git-trunk
> 
> BUILD FAILED
> /home/vjrj/proyectos/dev/wave/wiab/svn-git-trunk/server-config.xml:74: class org.apache.tools.ant.filters.ReplaceTokens
doesn't support nested text data (""
>       ...       "").
> 
> Total time: 0 seconds
> 
> So, this small patch fix that.
> 
> 
> Diffs
> -----
> 
>   server-config.xml 98c8c5e 
> 
> Diff: https://reviews.apache.org/r/7899/diff/
> 
> 
> Testing
> -------
> 
> ant -f server-config.xml
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message