incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix some regresion with new edit_done button patch (review 6336)
Date Sun, 21 Oct 2012 18:09:37 GMT


> On Aug. 13, 2012, 8:12 p.m., Ali Lown wrote:
> > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java,
line 133
> > <https://reviews.apache.org/r/6579/diff/1/?file=139050#file139050line133>
> >
> >     Did you mean for these to be a different order to MENU_OPTION_BEFORE_EDITING?
> >     
> >     (I think the order does matter looking at menuBuilder.outputHtml below)

ping


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6579/#review10237
-----------------------------------------------------------


On Aug. 13, 2012, 8:05 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6579/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2012, 8:05 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> In kune, we have detected a regression because of how we are now setting the initial
value of options in BlipMetaViewBuilder.
> 
> Before the inclusion of EDIT_DONE menu option, options where
> private final Set<MenuOption> options = EnumSet.allOf(MenuOption.class);
> 
> https://reviews.apache.org/r/6336/
> 
> The error is very odd, (we only see it in a custom FullDomRendered), but we recommend
to apply this patch to let BlipMetaViewBuilder more similar to the previous version.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java 45f074b

> 
> Diff: https://reviews.apache.org/r/6579/diff/
> 
> 
> Testing
> -------
> 
> Tests with "ant waveharness-hosted".
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message