incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Horizontal lines in the editor
Date Sun, 21 Oct 2012 18:08:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7364/#review12643
-----------------------------------------------------------


The patch LGTM, but can you please send link to the hr_line.png binary file or send it in
email?

- Yuri Zelikov


On Oct. 2, 2012, 9:26 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7364/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 9:26 a.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, Ali Lown, and Patrick Coleman.
> 
> 
> Description
> -------
> 
> This patch adds <hr/> to the wave editor, fixing part of the WAVE-340 issue.
> 
> So now exists a new button in the EditToolbar for that.
> 
> 
> This addresses bug WAVE-340.
>     https://issues.apache.org/jira/browse/WAVE-340
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/editor/Editor.css 58429fb 
>   src/org/waveprotocol/wave/client/editor/content/ContentDocument.java 528188f 
>   src/org/waveprotocol/wave/client/editor/content/paragraph/DefaultParagraphHtmlRenderer.java
b49c070 
>   src/org/waveprotocol/wave/client/editor/content/paragraph/Paragraph.java e8d01b9 
>   src/org/waveprotocol/wave/client/editor/content/paragraph/ParagraphBehaviour.java 6e48632

>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.css 8bf9970 
>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java 3da1588 
>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditorToolbarResources.java
5658c12 
>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/images/edit/hr_line.png PRE-CREATION

>   src/org/waveprotocol/wave/model/schema/conversation/ConversationSchemas.java e6f54ef

>   test/org/waveprotocol/wave/model/document/util/LineContainersTest.java 7cc6466 
> 
> Diff: https://reviews.apache.org/r/7364/diff/
> 
> 
> Testing
> -------
> 
> Normal testing with editor.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message