incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix for deadlock in UserManager
Date Mon, 01 Oct 2012 11:25:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7253/#review12062
-----------------------------------------------------------


I asked Andrew if he experienced similar issues on wiab.pro and he replied that yes and his
solution was to remove synchronization on userManager in ClientFrontendImpl.
I also tend to think that this is the probable source of deadlocks.
Would you like to try this change on kune and let me know if it solves the issue with deadlocks?

 String channelId = generateChannelID();
    UserManager userManager = waveletInfo.getUserManager(loggedInUser);
    //   synchronized (userManager) { A. Kaplanov
      WaveViewSubscription subscription =
          userManager.subscribe(waveId, waveletIdFilter, channelId, openListener);

- Yuri Zelikov


On Sept. 25, 2012, 12:13 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7253/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2012, 12:13 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> I think that the synchronized in UserManager.onUpdate can be the cause of the deadlock
in WAVE-372. As matchSubscriptions is synchronized I think is not necessary at onUndate (in
the same way onCommit is not synchronized).
> 
> But anyway, comments, welcome.
> 
> 
> This addresses bug WAVE-372.
>     https://issues.apache.org/jira/browse/WAVE-372
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/frontend/UserManager.java 35117f1 
> 
> Diff: https://reviews.apache.org/r/7253/diff/
> 
> 
> Testing
> -------
> 
> ./run-server.sh
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message