incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Fix for copy-paste in FF15
Date Tue, 25 Sep 2012 10:55:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7142/
-----------------------------------------------------------

(Updated Sept. 25, 2012, 10:55 a.m.)


Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.


Changes
-------

Patch updated. Now should apply to tip.


Description
-------

This patch fix the copy/paste issue in new ff15. I didn't find the root of the changes in
new FF that make the code to fail, but the implementation for webkit works for ff >= 15
 also while the previous ff implementation works for ff < 15. Probably we can find a better
solution with the help of this patch that "focus" in the problem.


This addresses bug WAVE-370.
    https://issues.apache.org/jira/browse/WAVE-370


Diffs (updated)
-----

  src/org/waveprotocol/wave/client/clipboard/PasteBufferImpl.java 3da6bfb 
  src/org/waveprotocol/wave/client/clipboard/PasteBufferImplFirefox.java 2b210bb 
  src/org/waveprotocol/wave/client/clipboard/PasteBufferImplOldFirefox.java PRE-CREATION 
  src/org/waveprotocol/wave/client/clipboard/PasteBufferImplSafari.java c04c49b 
  src/org/waveprotocol/wave/client/clipboard/PasteBufferImplSafariAndNewFirefox.java PRE-CREATION

  src/org/waveprotocol/wave/client/common/util/QuirksConstants.java 378e93d 
  src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java 6a22782 

Diff: https://reviews.apache.org/r/7142/diff/


Testing
-------

ant waveharness-hosted ; ant editor-hosted ; ant test-gwt (after the change in UserAgentRuntimeProperties
that allows to make paste tests in waveharness-hostes and editor-hosted and with specific
versions of FF, I did the test-gwt goal without failures)


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message