incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Review Request: Make the 'presented' websocket address configurable
Date Mon, 24 Sep 2012 18:38:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7230/
-----------------------------------------------------------

Review request for wave, Yuri Zelikov and Vicente J. Ruiz Jurado.


Description
-------

This extends vjrj's review to make the websocket domain configurable separately from the rest
of the server, by allowing the 'given' address/port to vary with the 'real' address/port (for
use behind firewalls, load balancers etc.)

In my situation, I needed to make the presented websocket address to be on port 443, but to
listen on port 9898 for the actual connection, since iptables maps 443 -> 9898 on the server
so that the WIAB server can run as non-root.


Diffs
-----

  /server-config.xml 1379829 
  /server.config.example 1379829 
  /src/org/waveprotocol/box/server/CoreSettings.java 1379829 
  /src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 1379829 

Diff: https://reviews.apache.org/r/7230/diff/


Testing
-------

works on my server.


Thanks,

Ali Lown


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message