incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix for copy-paste in FF15
Date Tue, 18 Sep 2012 09:05:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7142/#review11654
-----------------------------------------------------------


Hi, thanks for fixing this.
Just minor comments.


src/org/waveprotocol/wave/client/clipboard/PasteBufferImpl.java
<https://reviews.apache.org/r/7142/#comment25175>

    PasteBufferImplSafariAndNewFF ->
    PasteBufferImplSafariAndNewFirefox
    Let's follow the existing style and use full words in method names



src/org/waveprotocol/wave/client/clipboard/PasteBufferImplOldFirefox.java
<https://reviews.apache.org/r/7142/#comment25176>

    old - > older than 15.0?



src/org/waveprotocol/wave/client/common/util/QuirksConstants.java
<https://reviews.apache.org/r/7142/#comment25177>

    FIREFOX_GREAT_THAN_15 -> FIREFOX_GREATER_THAN_VER_15



src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java
<https://reviews.apache.org/r/7142/#comment25178>

    Why we need to use GWT.isClient() here?


- Yuri Zelikov


On Sept. 18, 2012, 3:21 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7142/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2012, 3:21 a.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> This patch fix the copy/paste issue in new ff15. I didn't find the root of the changes
in new FF that make the code to fail, but the implementation for webkit works for ff >=
15  also while the previous ff implementation works for ff < 15. Probably we can find a
better solution with the help of this patch that "focus" in the problem.
> 
> 
> This addresses bug WAVE-370.
>     https://issues.apache.org/jira/browse/WAVE-370
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/clipboard/PasteBufferImpl.java 3da6bfb 
>   src/org/waveprotocol/wave/client/clipboard/PasteBufferImplOldFirefox.java 2b210bb 
>   src/org/waveprotocol/wave/client/clipboard/PasteBufferImplSafariAndNewFF.java c04c49b

>   src/org/waveprotocol/wave/client/common/util/QuirksConstants.java 378e93d 
>   src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java 6a22782

> 
> Diff: https://reviews.apache.org/r/7142/diff/
> 
> 
> Testing
> -------
> 
> ant waveharness-hosted ; ant editor-hosted ; ant test-gwt (after the change in UserAgentRuntimeProperties
that allows to make paste tests in waveharness-hostes and editor-hosted and with specific
versions of FF, I did the test-gwt goal without failures)
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message