incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Set some timeout to webclient search requests
Date Sat, 01 Sep 2012 05:42:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6885/#review10968
-----------------------------------------------------------


I am not sure that aborting the request is the right way to handle this. Can we maybe track
search requests and buffer them until previous search request returned? This way we still
return the search response even if it took longer than 15 seconds but avoid processing another
one.

- Yuri Zelikov


On Sept. 1, 2012, 12:34 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6885/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2012, 12:34 a.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> This patch sets the same timeout to search queries that the search polling interval,
so if the server does not respond in time, the query is aborted.
> 
> 
> This addresses bug WAVE-367.
>     https://issues.apache.org/jira/browse/WAVE-367
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/search/JsoSearchBuilderImpl.java df37aa3 
>   src/org/waveprotocol/box/webclient/search/SearchPresenter.java b136c88 
> 
> Diff: https://reviews.apache.org/r/6885/diff/
> 
> 
> Testing
> -------
> 
> I was running the server with --debug and with a breakpoint in SearchServlet.doGet so
I see that client abort the query (with firebug) if the server does not respond in time.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message