incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Assume receivedTime = sentTime for blip display
Date Sat, 01 Sep 2012 00:42:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6777/#review10963
-----------------------------------------------------------

Ship it!


Ship It!

- Vicente J. Ruiz Jurado


On Aug. 31, 2012, 9:11 p.m., Ali Lown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6777/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 9:11 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Vicente J. Ruiz Jurado.
> 
> 
> Description
> -------
> 
> Following on from vjrj's review request #6339 which has stalled, I present my patch for
WAVE-181:
> 
> This assumes that the blip's received time is the same as the sent time (a reasonable
assumption for everything apart from a slow federation), and so displays the received time
to the user instead of the 1/1/1970 due to the current deficiency in the c/s protocol.
> 
> I am choosing to do this rather than attempt to fix the c/s protocol since the June discussions
showed an interest in changing the code organisation (and possibly protocols) -> which
would let us fix this properly.
> Also, with this patch, as far as a 'user' is concerned WAVE-181 would be fixed.
> At the least, it is better than simply hiding the date, since that renders it more difficult
for a 'user' to determine the order of a discussion.
> 
> Comments, and further discussion?
> 
> 
> This addresses bug WAVE-181.
>     https://issues.apache.org/jira/browse/WAVE-181
> 
> 
> Diffs
> -----
> 
>   /src/org/waveprotocol/wave/client/StageTwo.java 1379094 
>   /src/org/waveprotocol/wave/client/wavepanel/render/UndercurrentShallowBlipRenderer.java
1379094 
> 
> Diff: https://reviews.apache.org/r/6777/diff/
> 
> 
> Testing
> -------
> 
> Works on my machine between 2 users on the same server.
> Time discrepancies between this 'guessed' time, and the times recorded in a snapshot
varied by a maximum of a minute.
> 
> 
> Thanks,
> 
> Ali Lown
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message