incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Gadget width is 100% by default if the gadget not set its width
Date Mon, 13 Aug 2012 19:55:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6340/
-----------------------------------------------------------

(Updated Aug. 13, 2012, 7:55 p.m.)


Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.


Description
-------

Hi, by default the width of the gadgets are 600px if the gadget has not set its width. This
is quite arbitrary, IMHO, and gives many problems of rendering, offsets, etc.

This patch sets the default with to 100% also allow the use of percentages in gadget widths.


This addresses bug WAVE-309.
    https://issues.apache.org/jira/browse/WAVE-309


Diffs
-----

  src/org/waveprotocol/wave/client/gadget/renderer/Gadget.css ba87cf7 
  src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidget.java 1e38273 

Diff: https://reviews.apache.org/r/6340/diff/


Testing
-------

Tested with gadgets that sets the width (like Yes/No/Maybe) and others that do not set it
(the maps, for instance). In thouse, the width should occupy the 100% of the editor, even
if you use the split scroll.

Tested also in production.


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message