incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fixes WAVE-363 - number marks of unread blips dont changing in real time
Date Fri, 10 Aug 2012 10:08:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6475/#review10114
-----------------------------------------------------------


Committed as r1371635.

- Yuri Zelikov


On Aug. 8, 2012, 8:05 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6475/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 8:05 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> Fixes WAVE-363 - number marks of unread blips dont changing in real time. 
> The issue was originally caused by stopping the WaveBasedDigest to listen on wave events,
in order to prevent it from re-rendering itself on each key pressed and thus causing a lot
of flickering. 
> The new approach restores to the WaveBasedDigest to listen on events, but disables re-rendering
on last modified time change. 
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/search/SimpleSearch.java 28fb37d 
>   src/org/waveprotocol/box/webclient/search/WaveBasedDigest.java c826f05 
> 
> Diff: https://reviews.apache.org/r/6475/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message