incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fixes WAVE-312 - Not saving editions when concurrent editions in same wave
Date Wed, 08 Aug 2012 19:43:12 GMT


> On Aug. 8, 2012, 7:15 p.m., Ali Lown wrote:
> > Patch LGTM.
> > I am applying to my server to see if it works. (Poke me again in a weeks time)
> 
> Ali Lown wrote:
>     Edit: this patch seems to break the testDeltaHistoryRequiresCorrectHash test for
me?

Didn't run the test, I ll look into it. Thanks.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6474/#review10030
-----------------------------------------------------------


On Aug. 8, 2012, 6:49 p.m., Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6474/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 6:49 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Vicente J. Ruiz Jurado, and Ali Lown.
> 
> 
> Description
> -------
> 
> WAVE-312 - Not saving editions when concurrent editions in same wave
> 
> 
> This addresses bug WAVE-312.
>     https://issues.apache.org/jira/browse/WAVE-312
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java 98bed26

> 
> Diff: https://reviews.apache.org/r/6474/diff/
> 
> 
> Testing
> -------
> 
> Couldn't reproduce the issue after applying the patch.
> 
> 
> Thanks,
> 
> Yuri Zelikov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message