incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Done button to finish editing
Date Fri, 03 Aug 2012 11:17:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6336/#review9823
-----------------------------------------------------------

Ship it!


LGTM.
Just a minor comment, but I changed it by myself.
Committed as r1368892.


src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java
<https://reviews.apache.org/r/6336/#comment20840>

    EDITDONE -> EDIT_DONE


- Yuri Zelikov


On Aug. 3, 2012, 10:01 a.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6336/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 10:01 a.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> Addresses second part of WAVE-349, so now there is a new "done" button to stop editing
a blip.
> 
> 
> This addresses bug WAVE-349.
>     https://issues.apache.org/jira/browse/WAVE-349
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java 4d6f2ed 
>   src/org/waveprotocol/wave/client/wavepanel/impl/menu/MenuController.java 86b1e57 
>   src/org/waveprotocol/wave/client/wavepanel/view/IntrinsicBlipMetaView.java db1fe13

>   src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipMetaViewBuilder.java a783fe4

> 
> Diff: https://reviews.apache.org/r/6336/diff/
> 
> 
> Testing
> -------
> 
> Some tests with ant waveharness-hosted.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message