incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeremy Naegel" <jerry....@wavewatchers.org>
Subject Re: Review Request: Improving usability and visibility of inline replies
Date Thu, 02 Aug 2012 10:54:43 GMT


> On June 25, 2012, 6:54 p.m., Yuri Zelikov wrote:
> > src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ContinuationIndicator.css,
line 62
> > <https://reviews.apache.org/r/5426/diff/1/?file=112259#file112259line62>
> >
> >     I think that displaying only upper part of the "unknown" participant image doesn't
look good. It looks a bit weird to me.
> 
> Vicente J. Ruiz Jurado wrote:
>     Can you test the new patch? Also you can test it in action in http://kune.cc.

I've tested it on kune.cc and I think it makes the blue line inline reply more visible and
clearer to understand for newcomers.

Could it display (scaled down) the actual user avatar instead of the unknown one? IMHO that
would make its function even clearer.
What about adding the "Click here to reply" text in the blip preview? It would make it match
the reply box at the bottom of waves.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5426/#review8555
-----------------------------------------------------------


On June 25, 2012, 7:36 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5426/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 7:36 p.m.)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Description
> -------
> 
> Few people are using the inline reply (the on over blue border) compared to the use of
the "Reply" button.
> 
> This small patch improves the visibility and usability of the inline reply and I think
that encourage people to use it.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ContinuationIndicator.css
c2bc9a9 
> 
> Diff: https://reviews.apache.org/r/5426/diff/
> 
> 
> Testing
> -------
> 
> Tested with "ant waveharness-hosted".
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message