incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Websocket configurable in a different port and/or subdomain (#WAVE-357)
Date Thu, 02 Aug 2012 10:16:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5375/
-----------------------------------------------------------

(Updated Aug. 2, 2012, 10:16 a.m.)


Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.


Description
-------

The idea is that the client uses two configurable listening addresses:
- one for the normal traffic (all the common server petitions), the current http_frontend_public_address
- and a new one for the websocket traffic (that can be configured to a different subdomain
or port if it's necessary).

That is, we would be able to split these two different traffics. This would allow the use
of proxies, caches or CDNs for the "normal traffic".

Issue:
https://issues.apache.org/jira/browse/WAVE-357


Diffs (updated)
-----

  server-config.xml f55e440 
  server.config.example 02b27bc 
  src/org/waveprotocol/box/server/CoreSettings.java e95a920 
  src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp cea296a 
  src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 82c3c8d 
  src/org/waveprotocol/box/server/rpc/WaveClientServlet.java f8a95f2 
  src/org/waveprotocol/box/webclient/client/WebClient.java b16df98 

Diff: https://reviews.apache.org/r/5375/diff/


Testing
-------

Tested with different ports/subdomains, for example with this in /etc/hosts as websocket domain
127.0.0.1 ws.localhost
but also tested in a production server.


Thanks,

Vicente J. Ruiz Jurado


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message