incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paulo Pires <pjpi...@ubiwhere.com>
Subject Re: Maven Module for Protocol Buffers
Date Sun, 17 Jun 2012 18:37:35 GMT
Exactly and this is why at first i've removed them from the maven Project and get them compiled
on every build.
-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

Andreas Horst <horst.andreas82@googlemail.com> wrote:

Generated sources/resources do not belong into SCM at any time (IMHO). I'd
go with module separation in such cases.

Andreas

2012/6/17 Paulo Pires <pjpires@ubiwhere.com>

> +1
>
> PP
>
> On 17/06/12 09:40, Davide Carnovale wrote:
> > Hi all,
> > +1 to have it as a separate project. Imho it will help those who are not
> > working on it by the means of not having to care about protoc and it
> won't
> > add much complexity for those who need to work on that part
> >
> > D
> > Il giorno 17/giu/2012 04:49, "Michael MacFadden" <
> > michael.macfadden@gmail.com> ha scritto:
> >
> >> All,
> >>
> >> We are still contemplating the organization of the maven project.
> >> Currently, the protocol buffers are not built on every build. It seems
> >> that you generate them once (or when you change them) and then use the
> >> sources. Should we keep this similar in the maven build. We could put
> the
> >> protocol buffers in a separate project that gets built, versioned and
> >> released. Then the other maven modules could depend on this wave
> protobuf
> >> jar file. This way you would not need to compile the protocol buffers
> (or
> >> even have the compiler installed) unless you were specifically working
> on
> >> the protocol buffers.
> >>
> >> The alternative is to have the protobuf module in the main build. The
> >> protocol buffer source would get generated and then compiled in every
> >> build. Everyone working on wave in a box would need to have the protoc
> >> compile installed even if they aren't working on the protocol buffers.
> I
> >> would mention that the protobufs are already in a separate module, but
> the
> >> module is currently in the main build.
> >>
> >> Should we separate it out as described in the first paragraph?
> >>
> >> ~Michael
>
> --
> Paulo Pires
>
>


-- 
Andreas Horst
Heinrichsallee 21, 52062 Aachen
Tel. +49 (0)170 4162251, mailto:horst.andreas82@googlemail.com


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message