incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix avatar flickering while editing in chrome
Date Mon, 18 Jun 2012 19:07:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5257/#review8341
-----------------------------------------------------------



src/org/waveprotocol/box/webclient/search/SimpleSearch.java
<https://reviews.apache.org/r/5257/#comment17986>

    Can we just remove the line with commented code? We can add the line to the issue.


- Yuri Zelikov


On June 2, 2012, 12:05 p.m., Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5257/
> -----------------------------------------------------------
> 
> (Updated June 2, 2012, 12:05 p.m.)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Description
> -------
> 
> In chrome the avatars flicker while editing (on each key press). Not registering the
digest to wave changes fix the issue, and seems that the search panel updates correctly anyway
(on title change, adding/removing participants, etc).
> 
> I'm not an expert on this part of the code, so probably Yuri have to double check this
patch.
> 
> Related:
> https://kune.cc/?locale=es#kune.lists.1226.1257
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5240554 
> 
> Diff: https://reviews.apache.org/r/5257/diff/
> 
> 
> Testing
> -------
> 
> Normal use of the server in chrome.
> 
> 
> Thanks,
> 
> Vicente J. Ruiz Jurado
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message