incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix avatar flickering while editing in chrome
Date Fri, 01 Jun 2012 12:17:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5257/#review8285
-----------------------------------------------------------



src/org/waveprotocol/box/webclient/search/SimpleSearch.java
<https://reviews.apache.org/r/5257/#comment17909>

    Can you please open an issue for updating the re-rendering logic so only the changed digests
are re-rendered and then add TODO here to add the listener here to dynamic digest once the
issue would be addressed?


- Yuri


On 2012-05-29 10:48:22, Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5257/
> -----------------------------------------------------------
> 
> (Updated 2012-05-29 10:48:22)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Summary
> -------
> 
> In chrome the avatars flicker while editing (on each key press). Not registering the
digest to wave changes fix the issue, and seems that the search panel updates correctly anyway
(on title change, adding/removing participants, etc).
> 
> I'm not an expert on this part of the code, so probably Yuri have to double check this
patch.
> 
> Related:
> https://kune.cc/?locale=es#kune.lists.1226.1257
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5240554 
> 
> Diff: https://reviews.apache.org/r/5257/diff
> 
> 
> Testing
> -------
> 
> Normal use of the server in chrome.
> 
> 
> Thanks,
> 
> Vicente J.
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message