incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vicente J. Ruiz Jurado" <v...@ourproject.org>
Subject Re: Review Request: Fix avatar flickering while editing in chrome
Date Wed, 30 May 2012 08:20:21 GMT


> On 2012-05-29 17:29:08, Yuri Zelikov wrote:
> > Can we make this configurable by passing a flag to client in ClientFlags?

Yes, but, because I don't know well this part of the code, I'm not sure of the differences
between be notified of the wave changes or not. It's a way to update faster the search digest
and not to wait to the search query results? your proposal is to make this configurable in
server.config also? I prefer to find a better fix.


- Vicente J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5257/#review8175
-----------------------------------------------------------


On 2012-05-29 10:48:22, Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5257/
> -----------------------------------------------------------
> 
> (Updated 2012-05-29 10:48:22)
> 
> 
> Review request for wave and Yuri Zelikov.
> 
> 
> Summary
> -------
> 
> In chrome the avatars flicker while editing (on each key press). Not registering the
digest to wave changes fix the issue, and seems that the search panel updates correctly anyway
(on title change, adding/removing participants, etc).
> 
> I'm not an expert on this part of the code, so probably Yuri have to double check this
patch.
> 
> Related:
> https://kune.cc/?locale=es#kune.lists.1226.1257
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/search/SimpleSearch.java 5240554 
> 
> Diff: https://reviews.apache.org/r/5257/diff
> 
> 
> Testing
> -------
> 
> Normal use of the server in chrome.
> 
> 
> Thanks,
> 
> Vicente J.
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message