incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Remove useSocketIO configuration parameter
Date Tue, 29 May 2012 17:21:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5258/#review8172
-----------------------------------------------------------

Ship it!


LGTM
Committed as r1343860

- Yuri


On 2012-05-29 11:47:53, Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5258/
> -----------------------------------------------------------
> 
> (Updated 2012-05-29 11:47:53)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Summary
> -------
> 
> The server configuration parameter useSocketIO is not used now (in the past this parameter
was forcing the use of socketio). Currently WebClient.java try to use socketio only if websocket
is not available:
> 
> private native boolean useSocketIO() /*-{ return !window.WebSocket }-*/;
> 
> In the server socketio servlet and websocket servlet are available at the same time.
> 
> I think is better to remove this parameter because we pass it to the client but we are
not using it.
> 
> 
> Diffs
> -----
> 
>   server-config.xml ddfc669 
>   server.config.example cf8aeb1 
>   src/org/waveprotocol/box/server/CoreSettings.java 3df1eae 
>   src/org/waveprotocol/box/server/gxp/WaveClientPage.gxp 294212c 
>   src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 921979b 
> 
> Diff: https://reviews.apache.org/r/5258/diff
> 
> 
> Testing
> -------
> 
> ant dist-server && ./run-server.sh
> 
> 
> Thanks,
> 
> Vicente J.
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message