incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fix long paste of text in waves (WAVE-352)
Date Tue, 29 May 2012 10:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5256/#review8157
-----------------------------------------------------------



src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java
<https://reviews.apache.org/r/5256/#comment17673>

    Zero max idle time - means we don't want the websocket connection to expire. Is there
any scenario under which we would like the connection to expire so the user will be forced
to reload the wave to edit it/see updates?


- Yuri


On 2012-05-29 10:03:14, Vicente J. Ruiz Jurado wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5256/
> -----------------------------------------------------------
> 
> (Updated 2012-05-29 10:03:14)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Summary
> -------
> 
> This patch addresses:
> https://issues.apache.org/jira/browse/WAVE-352
> adding a new configuration parameter, so we can configure and increase the size of messages
in websocket.
> 
> 
> Diffs
> -----
> 
>   server-config.xml ddfc669 
>   server.config.example cf8aeb1 
>   src/org/waveprotocol/box/server/CoreSettings.java 3df1eae 
>   src/org/waveprotocol/box/server/ServerModule.java a28faa2 
>   src/org/waveprotocol/box/server/rpc/WebSocketServerChannel.java 65367c3 
> 
> Diff: https://reviews.apache.org/r/5256/diff
> 
> 
> Testing
> -------
> 
> The paste of a wikipedia article like:
> http://en.wikipedia.org/wiki/Apache_Wave
> in a wave now works without disconnections and data lost.
> 
> 
> Thanks,
> 
> Vicente J.
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message