incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Blip menu handles clicks instead of mouse down
Date Wed, 23 May 2012 18:11:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5180/#review8058
-----------------------------------------------------------

Ship it!


LGTM
Committed as r1341965.

- Yuri


On 2012-05-21 18:21:35, vjrj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5180/
> -----------------------------------------------------------
> 
> (Updated 2012-05-21 18:21:35)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Summary
> -------
> 
> With this patch blip menu items reacts to mouse clicks instead of mouse down events (similar
behaviour than the toolbar buttons).
> 
> (This feedback comes from a usability expert)
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/wavepanel/impl/menu/MenuController.java 99b8fac 
> 
> Diff: https://reviews.apache.org/r/5180/diff
> 
> 
> Testing
> -------
> 
> Some tests with "ant waveharness-hosted"
> 
> 
> Thanks,
> 
> vjrj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message