incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From v...@ourproject.org
Subject Re: Review Request: Adds shortcut Ctrl-K and Ctrl-Shift-K for create/remove links
Date Sat, 19 May 2012 21:29:36 GMT


> On 2012-05-14 17:15:59, Ali Lown wrote:
> > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java, line
75
> > <https://reviews.apache.org/r/5048/diff/3/?file=107821#file107821line75>
> >
> >     Ditto.

I'm often typing Ctrl+K without success because the patch is not committed :) 

Any problem to commit this?


- vjrj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5048/#review7847
-----------------------------------------------------------


On 2012-05-15 23:00:46, vjrj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5048/
> -----------------------------------------------------------
> 
> (Updated 2012-05-15 23:00:46)
> 
> 
> Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.
> 
> 
> Summary
> -------
> 
> This patch adds two new shortcuts (Ctrl+K, Ctrl+Shift+K) to the wave Editor to create/remove
links after some link text selection (to avoid the use of the mouse).
> 
> This is similar to Google Docs shortcut for link creation.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/client/common/util/EventWrapper.java a6ea974 
>   src/org/waveprotocol/wave/client/common/util/KeyCombo.java 43df6c9 
>   src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java b4f141b 
>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java eb8402c 
>   src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/5048/diff
> 
> 
> Testing
> -------
> 
> Tested in ff and in chrome.
> 
> 
> Thanks,
> 
> vjrj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message