incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Adds ability to display announcement on the top bar.
Date Mon, 14 May 2012 20:00:28 GMT


> On 2012-05-14 19:51:40, Ali Lown wrote:
> > Whilst there is nothing wrong with this code, it doesn't feel like a good way of
handling announcements (since it can only be set at server boot time).

Yeah, I know. Still better than nothing.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5114/#review7861
-----------------------------------------------------------


On 2012-05-14 19:40:09, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5114/
> -----------------------------------------------------------
> 
> (Updated 2012-05-14 19:40:09)
> 
> 
> Review request for wave, Michael MacFadden and Ali Lown.
> 
> 
> Summary
> -------
> 
> Adds ability to display announcement on the top bar. 
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/rpc/WaveClientServlet.java 921979b 
>   server-config.xml ddfc669 
>   server.config.example cf8aeb1 
>   src/org/waveprotocol/box/server/CoreSettings.java 3df1eae 
>   src/org/waveprotocol/box/server/gxp/TopBar.gxp a7a53ff 
> 
> Diff: https://reviews.apache.org/r/5114/diff
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message