incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request: Sets the current wave title also as the browser window title
Date Mon, 14 May 2012 17:08:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3530/#review7845
-----------------------------------------------------------

Ship it!


LGTM.

(Sorry, I lost this in my inbox)...

- Ali


On 2012-05-05 19:58:08, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3530/
> -----------------------------------------------------------
> 
> (Updated 2012-05-05 19:58:08)
> 
> 
> Review request for wave, Michael MacFadden and Ali Lown.
> 
> 
> Summary
> -------
> 
> Sets the current wave title also as the browser window title.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/webclient/client/StagesProvider.java ac9630f 
>   src/org/waveprotocol/box/webclient/client/WebClient.java 1862679 
>   src/org/waveprotocol/wave/client/wavepanel/impl/title/WindowTitleHandler.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/3530/diff
> 
> 
> Testing
> -------
> 
> Tested locally, verified that the wave title also set as browser window title.
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message