incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From v...@ourproject.org
Subject Re: Review Request: Adds shortcut Ctrl-K and Ctrl-Shift-K for create/remove links
Date Tue, 08 May 2012 18:14:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5048/
-----------------------------------------------------------

(Updated 2012-05-08 18:14:02.985381)


Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown.


Changes
-------

Added javadoc following Michael comments.


Summary
-------

This patch adds two new shortcuts (Ctrl+K, Ctrl+Shift+K) to the wave Editor to create/remove
links after some link text selection (to avoid the use of the mouse).

This is similar to Google Docs shortcut for link creation.


Diffs (updated)
-----

  src/org/waveprotocol/wave/client/common/util/EventWrapper.java a6ea974 
  src/org/waveprotocol/wave/client/common/util/KeyCombo.java 43df6c9 
  src/org/waveprotocol/wave/client/wavepanel/impl/edit/EditSession.java b4f141b 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java eb8402c 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java PRE-CREATION 

Diff: https://reviews.apache.org/r/5048/diff


Testing
-------

Tested in ff and in chrome.


Thanks,

vjrj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message