incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From v...@ourproject.org
Subject Re: Review Request: Adds Lucene based implementation of per user wave view provider
Date Tue, 01 May 2012 19:43:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4774/#review7438
-----------------------------------------------------------


LGTM (only some simple comments about licensing)


src/org/waveprotocol/box/server/waveserver/IndexException.java
<https://reviews.apache.org/r/4774/#comment16368>

    Copyright 2012 Apache Wave ... 



src/org/waveprotocol/box/server/waveserver/ReadableWaveletDataProvider.java
<https://reviews.apache.org/r/4774/#comment16365>

    Needs the license...



src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java
<https://reviews.apache.org/r/4774/#comment16367>

    I think that empty result is a good response... (Google does not return any error if you
use a bad query)



src/org/waveprotocol/box/server/waveserver/WaveIndexer.java
<https://reviews.apache.org/r/4774/#comment16366>

    License also...


- vjrj


On 2012-05-01 10:50:16, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4774/
> -----------------------------------------------------------
> 
> (Updated 2012-05-01 10:50:16)
> 
> 
> Review request for wave, Michael MacFadden, vjrj, Ali Lown, and Lennard de Rijk.
> 
> 
> Summary
> -------
> 
> Adds Lucene based implementation of per user wave view provider. The intention is to
keep in the memory only the index of waves and load the wavelets into memory only when requested.
> 
> The lucene jars can be downloaded from here:
> http://apache.spd.co.il/lucene/java/3.5.0/
> 
> 
> Diffs
> -----
> 
>   .classpath d8def03 
>   .gitignore 949276a 
>   build.xml f8cba2b 
>   server-config.xml 1dd74af 
>   server.config.example 50f80c4 
>   src/org/waveprotocol/box/server/CoreSettings.java 56c6c4a 
>   src/org/waveprotocol/box/server/SearchModule.java PRE-CREATION 
>   src/org/waveprotocol/box/server/ServerMain.java d7f22b7 
>   src/org/waveprotocol/box/server/ServerModule.java 3f1d3a2 
>   src/org/waveprotocol/box/server/frontend/ClientFrontendImpl.java 5238182 
>   src/org/waveprotocol/box/server/persistence/file/FileUtils.java c8b4894 
>   src/org/waveprotocol/box/server/persistence/lucene/FSIndexDirectory.java PRE-CREATION

>   src/org/waveprotocol/box/server/persistence/lucene/IndexDirectory.java PRE-CREATION

>   src/org/waveprotocol/box/server/persistence/lucene/RAMIndexDirectory.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/AbstractWaveIndexer.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/IndexException.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/IndexFieldType.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewHandlerImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/LuceneWaveIndexerImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewHandlerImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java 032a0ec 
>   src/org/waveprotocol/box/server/waveserver/MemoryWaveIndexerImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/NoOpWaveIndexerImpl.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewBus.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewDistpatcher.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewHandler.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewProvider.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java 23e0992 
>   src/org/waveprotocol/box/server/waveserver/ReadableWaveletDataProvider.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java PRE-CREATION

>   src/org/waveprotocol/box/server/waveserver/TextCollator.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/WaveIndexer.java PRE-CREATION 
>   src/org/waveprotocol/box/server/waveserver/WaveMap.java 273698b 
>   src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 38208c8 
>   src/org/waveprotocol/box/server/waveserver/WaveServerModule.java 9be5c3e 
>   test/org/waveprotocol/box/server/frontend/ClientFrontendImplTest.java 59bc10d 
>   test/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewProviderTest.java
PRE-CREATION 
>   test/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewProviderTest.java
PRE-CREATION 
>   test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java e31e9d1 
>   test/org/waveprotocol/box/server/waveserver/PerUserWaveViewDistpatcherTest.java PRE-CREATION

>   test/org/waveprotocol/box/server/waveserver/PerUserWaveViewProviderTestBase.java PRE-CREATION

>   test/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriberTest.java 007ccf4

>   test/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImplTest.java PRE-CREATION

>   third_party/runtime/lucene/COPYING PRE-CREATION 
>   third_party/runtime/lucene/README PRE-CREATION 
>   third_party/runtime/lucene/lucene-core-3.5.0-javadoc.jar PRE-CREATION 
>   third_party/runtime/lucene/lucene-core-3.5.0.jar PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/4774/diff
> 
> 
> Testing
> -------
> 
> Verified that the index is properly created and the search functionality works.
> All tests pass (besides WaveServerTest - issue WAVE-308).
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message