incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Fixes WaveId.serialize() to use Modern serializer.
Date Sat, 28 Apr 2012 15:11:03 GMT


> On 2012-04-28 14:00:16, Ali Lown wrote:
> > No testing done? Surely this could cause an issue with federation if one server
does not have this patch applied yet?

This patch fixes breakage in SearchServiceTest. Other tests also pass and WIAB works fine
locally.


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4925/#review7351
-----------------------------------------------------------


On 2012-04-28 12:37:08, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4925/
> -----------------------------------------------------------
> 
> (Updated 2012-04-28 12:37:08)
> 
> 
> Review request for wave, Michael MacFadden, Ali Lown, and Lennard de Rijk.
> 
> 
> Summary
> -------
> 
> Fixes WaveId.serialize() to use Modern serializer.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/wave/model/id/WaveId.java 3ca5400 
> 
> Diff: https://reviews.apache.org/r/4925/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message