incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Changes WaveId representation to the modern style.
Date Mon, 23 Apr 2012 14:50:02 GMT


> On 2012-04-23 14:47:28, maze wrote:
> > This change broke our existing waves. After logging in, the inbox stayed empty and
the following stack trace was immediately shown (replaced our domain with xxx.com):
> > 
> > Token:  1335192295655
> >  Class$NXf: Invalid id 'xxx.com/w+QAyhGJwY_YA': Wave id must be of the form <domain>!<id>
> >   Unknown.WF (Unknown source:0)
> >   Unknown.cG (Unknown source:0)
> >   Unknown.KWb (Unknown source:0)
> >   Unknown.CYf (Unknown source:0)
> >   Unknown.Jqc (Unknown source:0)
> >   Unknown.Kqc (Unknown source:0)
> >   Unknown.Gqc (Unknown source:0)
> > Caused by: Token:  1335192295655
> >  Invalid id 'xxx.com/w+QAyhGJwY_YA': Wave id must be of the form <domain>!<id>
> >   Unknown.WF (Unknown source:0)
> >   Unknown.PXf (Unknown source:0)
> >   Unknown.UXf (Unknown source:0)
> >   Unknown.CYf (Unknown source:0)
> >   Unknown.Jqc (Unknown source:0)
> >   Unknown.Kqc (Unknown source:0)
> >   Unknown.Gqc (Unknown source:0)
> > 
> > 
> > I had to revert the changes in order get our waves back. We have no special robots
or gadgets in use. 
> > 
> > Is this intended? Is there a way to "migrate" the old style waves?

Did you try to clean the browser cache?


- Yuri


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4828/#review7130
-----------------------------------------------------------


On 2012-04-20 12:49:04, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4828/
> -----------------------------------------------------------
> 
> (Updated 2012-04-20 12:49:04)
> 
> 
> Review request for wave, Michael MacFadden and Ali Lown.
> 
> 
> Summary
> -------
> 
> Changes WaveId representation to the modern style: using '/' as separator instead of
'!'. This is required for consistency as most of the WIAB already uses the modern '/' separator
while the Robot API still returns old waveId representation.
> The change might break some robots that were built for WIAB, but I don't think there
are too many yet.
> 
> 
> Diffs
> -----
> 
>   src/com/google/wave/api/ApiIdSerializer.java 674f235 
>   src/org/waveprotocol/wave/model/id/WaveId.java 45c0d6f 
> 
> Diff: https://reviews.apache.org/r/4828/diff
> 
> 
> Testing
> -------
> 
> Checked that all test pass.
> Verified the web client works.
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message