incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ali Lown" <...@lown.me.uk>
Subject Re: Review Request: Adds notifier servlet
Date Sat, 21 Apr 2012 18:40:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4829/#review7114
-----------------------------------------------------------

Ship it!


LGTM

- Ali


On 2012-04-20 12:59:24, Yuri Zelikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4829/
> -----------------------------------------------------------
> 
> (Updated 2012-04-20 12:59:24)
> 
> 
> Review request for wave, Michael MacFadden and Ali Lown.
> 
> 
> Summary
> -------
> 
> Adds notifier servlet that serves search digests for users in JSON format - to allow
easier integration with "Notifier" Chrome extension.
> 
> 
> Diffs
> -----
> 
>   src/org/waveprotocol/box/server/ServerMain.java 5910c88 
>   src/org/waveprotocol/box/server/rpc/AbstractSearchServlet.java PRE-CREATION 
>   src/org/waveprotocol/box/server/rpc/NotificationServlet.java PRE-CREATION 
>   src/org/waveprotocol/box/server/rpc/SearchServlet.java 7302b85 
> 
> Diff: https://reviews.apache.org/r/4829/diff
> 
> 
> Testing
> -------
> 
> Tested that /notification/ correctly returns the user digests and search still works.
> 
> 
> Thanks,
> 
> Yuri
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message