incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Adds Lucene based implementation of per user wave view provider
Date Sat, 21 Apr 2012 11:53:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4774/
-----------------------------------------------------------

(Updated 2012-04-21 11:53:12.351474)


Review request for wave, Michael MacFadden, vjrj, Ali Lown, and Lennard de Rijk.


Changes
-------

Addressed comments + added some precondition checks.


Summary
-------

Adds Lucene based implementation of per user wave view provider. The intention is to keep
in the memory only the index of waves and load the wavelets into memory only when requested.

The lucene jars can be downloaded from here:
http://apache.spd.co.il/lucene/java/3.5.0/


Diffs (updated)
-----

  src/org/waveprotocol/box/server/waveserver/MemoryWaveIndexerImpl.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/NoOpWaveIndexerImpl.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/PerUserWaveViewBus.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/PerUserWaveViewDistpatcher.java PRE-CREATION

  src/org/waveprotocol/box/server/waveserver/PerUserWaveViewHandler.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/PerUserWaveViewProvider.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriber.java 23e0992 
  src/org/waveprotocol/box/server/waveserver/ReadableWaveletDataProvider.java PRE-CREATION

  src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/TextCollator.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/WaveIndexer.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/WaveMap.java a0d72d6 
  src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java 38208c8 
  src/org/waveprotocol/box/server/waveserver/WaveServerModule.java eb43a5c 
  test/org/waveprotocol/box/server/frontend/ClientFrontendImplTest.java 59bc10d 
  test/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewProviderTest.java PRE-CREATION

  test/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewProviderTest.java PRE-CREATION

  test/org/waveprotocol/box/server/waveserver/MemorySearchProviderTest.java 3a2ae13 
  third_party/runtime/lucene/COPYING PRE-CREATION 
  test/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImplTest.java PRE-CREATION

  test/org/waveprotocol/box/server/waveserver/PerUserWaveViewProviderTestBase.java PRE-CREATION

  test/org/waveprotocol/box/server/waveserver/PerUserWaveViewSubscriberTest.java 007ccf4 
  test/org/waveprotocol/box/server/waveserver/PerUserWaveViewDistpatcherTest.java PRE-CREATION

  third_party/runtime/lucene/lucene-core-3.5.0-javadoc.jar PRE-CREATION 
  third_party/runtime/lucene/lucene-core-3.5.0.jar PRE-CREATION 
  third_party/runtime/lucene/README PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/MemorySearchProvider.java 032a0ec 
  src/org/waveprotocol/box/server/waveserver/LuceneWaveIndexerImpl.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/MemoryPerUserWaveViewHandlerImpl.java PRE-CREATION

  src/org/waveprotocol/box/server/ServerModule.java 4debe3b 
  src/org/waveprotocol/box/server/frontend/ClientFrontendImpl.java 5238182 
  src/org/waveprotocol/box/server/persistence/file/FileUtils.java c8b4894 
  src/org/waveprotocol/box/server/persistence/lucene/FSIndexDirectory.java PRE-CREATION 
  src/org/waveprotocol/box/server/persistence/lucene/IndexDirectory.java PRE-CREATION 
  src/org/waveprotocol/box/server/persistence/lucene/RAMIndexDirectory.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/AbstractWaveIndexer.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/IndexException.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/IndexFieldType.java PRE-CREATION 
  src/org/waveprotocol/box/server/waveserver/LucenePerUserWaveViewHandlerImpl.java PRE-CREATION

  .gitignore 949276a 
  build.xml f8cba2b 
  server-config.xml 65c6d62 
  server.config.example 7990e6e 
  src/org/waveprotocol/box/server/CoreSettings.java a28ec66 
  src/org/waveprotocol/box/server/SearchModule.java PRE-CREATION 
  src/org/waveprotocol/box/server/ServerMain.java 5910c88 
  .classpath d8def03 

Diff: https://reviews.apache.org/r/4774/diff


Testing
-------

Verified that the index is properly created and the search functionality works.
All tests pass (besides WaveServerTest - issue WAVE-308).


Thanks,

Yuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message