incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Review Request: Changes WaveId representation to the modern style.
Date Fri, 20 Apr 2012 12:49:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4828/
-----------------------------------------------------------

Review request for wave, Michael MacFadden and Ali Lown.


Summary
-------

Changes WaveId representation to the modern style: using '/' as separator instead of '!'.
This is required for consistency as most of the WIAB already uses the modern '/' separator
while the Robot API still returns old waveId representation.
The change might break some robots that were built for WIAB, but I don't think there are too
many yet.


Diffs
-----

  src/com/google/wave/api/ApiIdSerializer.java 674f235 
  src/org/waveprotocol/wave/model/id/WaveId.java 45c0d6f 

Diff: https://reviews.apache.org/r/4828/diff


Testing
-------

Checked that all test pass.
Verified the web client works.


Thanks,

Yuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message