incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Zelikov" <vega...@gmail.com>
Subject Re: Review Request: Avoid crash due to IAE in link annotation converter.
Date Wed, 18 Apr 2012 06:39:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4769/
-----------------------------------------------------------

(Updated 2012-04-18 06:39:48.531962)


Review request for wave, Michael MacFadden and Christian Ohler.


Changes
-------

Fixes test compilation issue.


Summary
-------

Avoid crash due to IAE in link annotation converter - adopted from patch to Walkaround by
Christian Ohler http://code.google.com/p/walkaround/source/detail?r=a7ce6506637f8d50024f144acd2f049a6c769923


Diffs (updated)
-----

  src/org/waveprotocol/wave/client/wavepanel/view/dom/FullStructure.java daa3810 
  src/org/waveprotocol/wave/client/wavepanel/view/dom/ParticipantAvatarDomImpl.java f0c47d9

  src/org/waveprotocol/wave/migration/helpers/FixLinkAnnotationsFilter.java f824113 
  src/org/waveprotocol/wave/model/waveref/InvalidWaveRefException.java ef83673 
  src/org/waveprotocol/wave/model/waveref/WaverefEncoder.java 9c69bcc 
  test/org/waveprotocol/wave/model/waveref/WaverefEncoderTest.java ad724d8 
  src/org/waveprotocol/wave/client/wavepanel/impl/edit/KeepFocusInView.java 6aa4c2f 

Diff: https://reviews.apache.org/r/4769/diff


Testing
-------


Thanks,

Yuri


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message