incubator-wave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lennard de Rijk <>
Subject Re: Proposal regarding code reviews and submitting
Date Fri, 29 Apr 2011 08:51:38 GMT
Hi Daniel,

On Fri, Apr 29, 2011 at 09:43, Daniel Danilatos <>wrote:

> I think it would be a good practice if everyone puts a link to the
> code review in the commit message. This makes it very easy to see the
> discussions/justifications that happened on a particular change.
> Thoughts?

I totally agree with this. During my time on the project I've always tried
to indicate the number of the review in Rietveld and who reviewed it. It
sounds like a very nice idea if this practice could be continued when we
migrated to Apache.


  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message