incubator-wave-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From " (Commented) (JIRA)" <>
Subject [jira] [Commented] (WAVE-319) Improve the "Add gadget" popup
Date Sat, 24 Mar 2012 13:32:27 GMT

] commented on WAVE-319:

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-03-24 13:30:50.312549)

Review request for wave.


Updated according to the comments. Thanks.

The reason why I have GWTTestCase instead of normal TestCase is that it is needed for the
JSON parsing to work.


* Added more gadgets to the gadget list
* Made the gadget list scrollable and filterable through a text box and a drop down box for
* The filtering looks at both the name of the gadget and its description. Author could also
be added as a searchable property (?)
* Filter the result directly in the scrollable gadget list
* Marking the top filtered search as selected with gray background and made it possible to
choose that gadget by pressing enter
* Change the default focus to the filter box to allow the user to quickly select a gadget
from the list by filter it out and pressing enter

This addresses bug wave-319.

Diffs (updated)

  jsongadgets.json PRE-CREATION 
  src/org/waveprotocol/box/server/ 13a2d55 
  src/org/waveprotocol/box/server/persistence/file/ 538e6e3 
  src/org/waveprotocol/box/server/rpc/ PRE-CREATION 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/ 3a470e0 
  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/ PRE-CREATION

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/ 97611b4

  src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/gadget/GadgetInfoWidget.ui.xml c8b7a81

  src/org/waveprotocol/wave/client/widget/popup/ 555f32e 
  src/org/waveprotocol/wave/client/widget/popup/ 5e3bab4 



Tested locally.
Successfully run all junit test (Except PerUserWaveViewSubscriberTest::testGetPerUserWaveView
and WaveServerTest::testWaveletNotification that fails even before this patch)
Tested all included gadgets



> Improve the "Add gadget" popup 
> -------------------------------
>                 Key: WAVE-319
>                 URL:
>             Project: Wave
>          Issue Type: Improvement
>          Components: Web Client
>            Reporter: Yuri Zelikov
>            Assignee: Olof
>            Priority: Minor
>              Labels: StarterProject
> Improve the "Add gadget" popup. Currently it contains only a handful of gadgets. Add
more gadget definitions, make the panel scrollable, add ability to filter the gadgets list
and or add suggestion box -!CwSuggestBox
> The gadget definitions can be taken from

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message