incubator-wave-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WAVE-317) Allow adding (copy/pasting) multiple participants into a wave
Date Mon, 13 Feb 2012 22:57:05 GMT

    [ https://issues.apache.org/jira/browse/WAVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207305#comment-13207305
] 

jiraposter@reviews.apache.org commented on WAVE-317:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3882/
-----------------------------------------------------------

Review request for wave.


Summary
-------

Implemented as suggested in the jira-issue as a client side implementation in ParticipantController.java.
I selected the separator for the multiple participant list to be semi-colon(;).


This addresses bug wave-317.
    https://issues.apache.org/jira/browse/wave-317


Diffs
-----

  "a/C://wintmp//Par1B9.tmp//ParticipantController-HEAD-left.java" ec9e25a 

Diff: https://reviews.apache.org/r/3882/diff


Testing
-------

Compiled and run.

* Tested to add single as well as multiple participants
* Tested to add participants both with and without @localhost
* Tested to add invalid participants


Thanks,

rocklund


                
> Allow adding (copy/pasting) multiple participants into a wave
> -------------------------------------------------------------
>
>                 Key: WAVE-317
>                 URL: https://issues.apache.org/jira/browse/WAVE-317
>             Project: Wave
>          Issue Type: New Feature
>          Components: Web Client
>            Reporter: Yuri Zelikov
>            Priority: Minor
>              Labels: StarterProject
>
> I think it would be nice to allow to paste/enter multiple participant ids separated by
comma into the "add participant" dialog box. The list will be parsed/validated by the client
and interpreted like it the user added these participants one by one. This way it would be
easier to create waves with multiple participants.
> The code is handled in ParticipantController.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message