incubator-thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Goldblatt (JIRA)" <j...@apache.org>
Subject [jira] Commented: (THRIFT-409) Add "union" to Thrift
Date Thu, 06 Aug 2009 19:21:14 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740209#action_12740209
] 

David Goldblatt commented on THRIFT-409:
----------------------------------------

I read through thrift-409-v4.patch and saw a couple pointer versus value issues:

187: value_ = other.value_
781: getFieldValue() == other.getFieldValue()

The todo on 237 is probably worth doing, since a default constructor is declared.

> Add "union" to Thrift
> ---------------------
>
>                 Key: THRIFT-409
>                 URL: https://issues.apache.org/jira/browse/THRIFT-409
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>             Fix For: 0.2
>
>         Attachments: one_rule.diff, thrift-409-v2.patch, thrift-409-v3.patch, thrift-409-v4.patch,
thrift-409.patch
>
>
> It would be very helpful to have a "union" construct in Thrift. Let's decide on the design
and then break up into sub-issues to add this feature.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message