incubator-tashi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From strou...@apache.org
Subject svn commit: r1338295 - /incubator/tashi/trunk/src/tashi/agents/dhcpdns.py
Date Mon, 14 May 2012 17:08:23 GMT
Author: stroucki
Date: Mon May 14 17:08:22 2012
New Revision: 1338295

URL: http://svn.apache.org/viewvc?rev=1338295&view=rev
Log:
dhcpdns: make note of need to log configuration failure

Modified:
    incubator/tashi/trunk/src/tashi/agents/dhcpdns.py

Modified: incubator/tashi/trunk/src/tashi/agents/dhcpdns.py
URL: http://svn.apache.org/viewvc/incubator/tashi/trunk/src/tashi/agents/dhcpdns.py?rev=1338295&r1=1338294&r2=1338295&view=diff
==============================================================================
--- incubator/tashi/trunk/src/tashi/agents/dhcpdns.py (original)
+++ incubator/tashi/trunk/src/tashi/agents/dhcpdns.py Mon May 14 17:08:22 2012
@@ -93,6 +93,8 @@ class DhcpDns(InstanceHook):
 		return "%d.%d.%d.%d" % ((ip>>24)&0xff, (ip>>16)&0xff, (ip>>8)&0xff,
ip&0xff)
 	
 	def allocateIP(self, nic):
+		# XXXstroucki: if the network is not defined having an ip
+		# range, this will throw a KeyError. Should be logged.
 		network = nic.network
 		allocatedIP = None
 		requestedIP = self.strToIp(nic.ip)



Mime
View raw message