From dev-return-8786-apmail-stdcxx-dev-archive=stdcxx.apache.org@stdcxx.apache.org Mon Sep 24 05:20:09 2012 Return-Path: X-Original-To: apmail-stdcxx-dev-archive@www.apache.org Delivered-To: apmail-stdcxx-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73702D4D7 for ; Mon, 24 Sep 2012 05:20:09 +0000 (UTC) Received: (qmail 55079 invoked by uid 500); 24 Sep 2012 05:20:09 -0000 Delivered-To: apmail-stdcxx-dev-archive@stdcxx.apache.org Received: (qmail 54907 invoked by uid 500); 24 Sep 2012 05:20:05 -0000 Mailing-List: contact dev-help@stdcxx.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@stdcxx.apache.org Delivered-To: mailing list dev@stdcxx.apache.org Received: (qmail 54805 invoked by uid 99); 24 Sep 2012 05:20:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 05:20:02 +0000 X-ASF-Spam-Status: No, hits=1.6 required=5.0 tests=SPF_PASS,SUBJ_ALL_CAPS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [64.78.233.62] (HELO moroha.roguewave.com) (64.78.233.62) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 05:19:55 +0000 Received: from vw-fw.roguewave.com (eagle.blue.roguewave.com [10.50.5.40]) by moroha.roguewave.com (8.13.6/8.13.6) with ESMTP id q8O5JWof022183 for ; Mon, 24 Sep 2012 05:19:32 GMT Received: from Eagle.Blue.Roguewave.Com ([fe80::8c9b:6e2c:c1ae:c417]) by Eagle.Blue.Roguewave.Com ([fe80::8c9b:6e2c:c1ae:c417%10]) with mapi; Sun, 23 Sep 2012 23:19:32 -0600 From: Travis Vitek To: "dev@stdcxx.apache.org" Date: Sun, 23 Sep 2012 23:18:01 -0600 Subject: RE: [PATCH] STDCXX-853 Thread-Topic: [PATCH] STDCXX-853 Thread-Index: Ac2ZoUzepTTJ0YovT2Sh876PL6xbYQAcqr2Z Message-ID: <53D52D02E87FA04A948D9A74A7AE617C12E83AA690@Eagle.Blue.Roguewave.Com> References: <505F2C02.3080906@hates.ms> In-Reply-To: <505F2C02.3080906@hates.ms> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Liviu, Should the volatile be to the left of the intT typename here? I know it is = equivalent, but it is weird to look at the line of code below and see that = we're following two different conventions. Travis _______________________________________ From: Liviu Nicoara Sent: Sunday, September 23, 2012 8:34 AM To: dev@stdcxx.apache.org Subject: [PATCH] STDCXX-853 Umm, I didn't think to search for a corresponding incident and I considered= the defect to be so minor as to not warrant an issue. The following patch = has been applied already on 4.2.x: Index: tests/support/atomic_xchg.cpp =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- tests/support/atomic_xchg.cpp (revision 1388732) +++ tests/support/atomic_xchg.cpp (revision 1388733) @@ -297,7 +297,7 @@ void run_test (intT, thr_args_base::tag_ // compute the expected result, "skipping" zeros by incrementing // expect twice when it overflows and wraps around to 0 (zero is // used as the lock variable in thread_routine() above) - intT expect =3D intT (1); + intT volatile expect =3D intT (1); const unsigned long nincr =3D (Args::nthreads_ * Args::nincr_) / 2U;